Improve workspace search and responsive shell
This commit is contained in:
parent
578ce2f2a5
commit
80e53ff252
|
|
@ -0,0 +1,87 @@
|
||||||
|
# UX/UI Refactor Plan
|
||||||
|
|
||||||
|
## Assumptions
|
||||||
|
|
||||||
|
- `verstak-desktop` is the core platform and UI shell. Notes, files, editor, activity, journal, browser inbox, and search behavior stay plugin-owned.
|
||||||
|
- The old `~/git/verstak` UI is a visual and interaction reference, not an architecture source.
|
||||||
|
- The v2 shell should improve orientation, density, keyboard/mouse ergonomics, and responsive behavior without reintroducing the v1 monolith.
|
||||||
|
|
||||||
|
## Reference Rules
|
||||||
|
|
||||||
|
Keep from v1:
|
||||||
|
|
||||||
|
- compact dark workbench rhythm;
|
||||||
|
- clear title/header zones;
|
||||||
|
- dense rows and tabs for repeated work;
|
||||||
|
- action controls that appear where the user is working;
|
||||||
|
- custom, in-app interaction surfaces instead of browser-default dialogs where the flow is important.
|
||||||
|
|
||||||
|
Avoid from v1:
|
||||||
|
|
||||||
|
- putting user business workflows into `App.svelte`;
|
||||||
|
- direct coupling between shell and notes/files/editor internals;
|
||||||
|
- global mutable UI state that plugins must know about;
|
||||||
|
- moving plugin behavior into core for visual convenience.
|
||||||
|
|
||||||
|
## Mimo Delegation Model
|
||||||
|
|
||||||
|
Use `~/bin/mimo.sh run --dir <repo> "<task>"` only for bounded junior tasks.
|
||||||
|
|
||||||
|
Good tasks:
|
||||||
|
|
||||||
|
- compare two small components and write a short report to `/tmp`;
|
||||||
|
- draft CSS for a named component within existing tokens;
|
||||||
|
- inspect one test file and suggest missing assertions;
|
||||||
|
- make a one-component mechanical change after the target behavior is already specified.
|
||||||
|
|
||||||
|
Do not delegate:
|
||||||
|
|
||||||
|
- architecture decisions;
|
||||||
|
- plugin/core boundary decisions;
|
||||||
|
- final diff review;
|
||||||
|
- verification claims;
|
||||||
|
- commits or pushes.
|
||||||
|
|
||||||
|
Every mimo result must be reviewed with `git diff` and verified independently.
|
||||||
|
|
||||||
|
## Work Plan
|
||||||
|
|
||||||
|
1. Shell orientation
|
||||||
|
- Move persistent search and workspace context into the workspace header.
|
||||||
|
- Keep exactly one global search entry visible at a time.
|
||||||
|
- Preserve search availability in global plugin views.
|
||||||
|
|
||||||
|
2. Responsive shell
|
||||||
|
- Make narrow viewports usable by stacking sidebar above workspace content.
|
||||||
|
- Ensure tabs and workspace cards do not force horizontal page overflow.
|
||||||
|
- Add Playwright coverage for mobile geometry.
|
||||||
|
|
||||||
|
3. Today surface
|
||||||
|
- Make Today feel like a work-resume surface, not a static card grid.
|
||||||
|
- Keep data loading from plugin settings/contributions; do not add business logic to core.
|
||||||
|
- Improve empty states and quick actions based on available workspace tools.
|
||||||
|
|
||||||
|
4. Plugin manager polish
|
||||||
|
- Improve scanning, status density, and permission readability.
|
||||||
|
- Keep enable/disable/status behavior unchanged.
|
||||||
|
- Verify degraded/failed/disabled plugin paths.
|
||||||
|
|
||||||
|
5. Files/workbench ergonomics
|
||||||
|
- Use the existing files plugin comparison report as input.
|
||||||
|
- Prefer plugin-local improvements: context menu, keyboard navigation, selection, and custom confirmation.
|
||||||
|
- Do not add file-manager logic to the shell.
|
||||||
|
|
||||||
|
## Verification Gates
|
||||||
|
|
||||||
|
Before commit:
|
||||||
|
|
||||||
|
- `npm run build`
|
||||||
|
- focused Playwright suite for the touched flow
|
||||||
|
- full `npm run test:e2e` when App, Sidebar, WorkspaceHost, PluginManager, or shared shell layout changes
|
||||||
|
- desktop and mobile screenshots inspected manually
|
||||||
|
|
||||||
|
Before push:
|
||||||
|
|
||||||
|
- re-run the relevant verification from a clean current worktree state;
|
||||||
|
- inspect `git status` and `git diff --stat`;
|
||||||
|
- push only after tests and visual smoke have current evidence.
|
||||||
|
|
@ -11,10 +11,12 @@ test.describe('UX follow-up fixes', () => {
|
||||||
test('global search stays available after opening tool sidebar views', async ({ page }) => {
|
test('global search stays available after opening tool sidebar views', async ({ page }) => {
|
||||||
const search = page.locator('[data-global-search-input]');
|
const search = page.locator('[data-global-search-input]');
|
||||||
await expect(search).toBeVisible();
|
await expect(search).toBeVisible();
|
||||||
|
await expect(page.locator('.workspace-header [data-global-search-input]')).toBeVisible();
|
||||||
|
|
||||||
await page.locator('.sidebar .nav-item').filter({ hasText: 'Activity' }).click();
|
await page.locator('.sidebar .nav-item').filter({ hasText: 'Activity' }).click();
|
||||||
await expect(page.locator('.activity-root')).toBeVisible({ timeout: 10000 });
|
await expect(page.locator('.activity-root')).toBeVisible({ timeout: 10000 });
|
||||||
await expect(search).toBeVisible();
|
await expect(search).toBeVisible();
|
||||||
|
await expect(page.locator('.sidebar [data-global-search-input]')).toBeVisible();
|
||||||
|
|
||||||
await page.locator('.sidebar .nav-item').filter({ hasText: 'Browser Inbox' }).click();
|
await page.locator('.sidebar .nav-item').filter({ hasText: 'Browser Inbox' }).click();
|
||||||
await expect(page.locator('.browser-inbox-root')).toBeVisible({ timeout: 10000 });
|
await expect(page.locator('.browser-inbox-root')).toBeVisible({ timeout: 10000 });
|
||||||
|
|
@ -87,6 +89,22 @@ test.describe('UX follow-up fixes', () => {
|
||||||
await expect(searchInput).toHaveValue('pr');
|
await expect(searchInput).toHaveValue('pr');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('mobile workspace layout gives content full width below the sidebar', async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width: 390, height: 844 });
|
||||||
|
await page.reload();
|
||||||
|
await waitForAppReady(page);
|
||||||
|
|
||||||
|
const workspaceBox = await page.locator('.workspace-host').boundingBox();
|
||||||
|
const sidebarBox = await page.locator('.sidebar').boundingBox();
|
||||||
|
expect(workspaceBox.width).toBeGreaterThan(340);
|
||||||
|
expect(workspaceBox.y).toBeGreaterThan(sidebarBox.y + sidebarBox.height - 1);
|
||||||
|
await expect(page.locator('.workspace-header [data-global-search-input]')).toBeVisible();
|
||||||
|
await expect(page.getByRole('tab', { name: 'Today' })).toBeVisible();
|
||||||
|
|
||||||
|
const hasHorizontalOverflow = await page.evaluate(() => document.documentElement.scrollWidth > window.innerWidth);
|
||||||
|
expect(hasHorizontalOverflow).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
test('plugin settings modal gives complex panels enough space', async ({ page }) => {
|
test('plugin settings modal gives complex panels enough space', async ({ page }) => {
|
||||||
await openPluginManager(page);
|
await openPluginManager(page);
|
||||||
await page.locator('.plugin-card').filter({ hasText: 'verstak.platform-test' }).getByRole('button', { name: 'Settings' }).click();
|
await page.locator('.plugin-card').filter({ hasText: 'verstak.platform-test' }).getByRole('button', { name: 'Settings' }).click();
|
||||||
|
|
|
||||||
|
|
@ -385,7 +385,7 @@
|
||||||
<VaultSelection />
|
<VaultSelection />
|
||||||
{:else}
|
{:else}
|
||||||
<main>
|
<main>
|
||||||
<Sidebar />
|
<Sidebar showGlobalSearch={currentView !== 'workspace' && currentView !== 'workspace-empty'} />
|
||||||
<CommandPalette />
|
<CommandPalette />
|
||||||
|
|
||||||
<section class="content-shell">
|
<section class="content-shell">
|
||||||
|
|
@ -576,4 +576,14 @@
|
||||||
flex-direction: column;
|
flex-direction: column;
|
||||||
padding: clamp(1rem, 2vw, 1.5rem);
|
padding: clamp(1rem, 2vw, 1.5rem);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@media (max-width: 720px) {
|
||||||
|
main {
|
||||||
|
flex-direction: column;
|
||||||
|
}
|
||||||
|
|
||||||
|
.content {
|
||||||
|
padding: 0.75rem;
|
||||||
|
}
|
||||||
|
}
|
||||||
</style>
|
</style>
|
||||||
|
|
|
||||||
|
|
@ -6,6 +6,8 @@
|
||||||
import Icon from '../ui/Icon.svelte';
|
import Icon from '../ui/Icon.svelte';
|
||||||
import { debug } from '../log/debug.js';
|
import { debug } from '../log/debug.js';
|
||||||
|
|
||||||
|
export let showGlobalSearch = true;
|
||||||
|
|
||||||
function flog(msg) {
|
function flog(msg) {
|
||||||
App.WriteFrontendLog('Sidebar', msg);
|
App.WriteFrontendLog('Sidebar', msg);
|
||||||
}
|
}
|
||||||
|
|
@ -77,7 +79,7 @@
|
||||||
<span class="sidebar-title">Verstak</span>
|
<span class="sidebar-title">Verstak</span>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{#if vaultOpen}
|
{#if vaultOpen && showGlobalSearch}
|
||||||
<GlobalSearch />
|
<GlobalSearch />
|
||||||
{/if}
|
{/if}
|
||||||
|
|
||||||
|
|
@ -223,4 +225,27 @@
|
||||||
:global(.sidebar-error-icon) {
|
:global(.sidebar-error-icon) {
|
||||||
color: #e94560;
|
color: #e94560;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@media (max-width: 720px) {
|
||||||
|
.sidebar {
|
||||||
|
width: 100%;
|
||||||
|
min-width: 0;
|
||||||
|
max-height: 14rem;
|
||||||
|
border-right: 0;
|
||||||
|
border-bottom: 1px solid #0f3460;
|
||||||
|
}
|
||||||
|
|
||||||
|
.sidebar-header {
|
||||||
|
padding: 0.75rem 1rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.sidebar-section {
|
||||||
|
max-height: 5.5rem;
|
||||||
|
overflow: auto;
|
||||||
|
}
|
||||||
|
|
||||||
|
.sidebar-footer {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
}
|
||||||
</style>
|
</style>
|
||||||
|
|
|
||||||
|
|
@ -1,5 +1,6 @@
|
||||||
<script>
|
<script>
|
||||||
import PluginBundleHost from '../plugin-host/PluginBundleHost.svelte';
|
import PluginBundleHost from '../plugin-host/PluginBundleHost.svelte';
|
||||||
|
import GlobalSearch from './GlobalSearch.svelte';
|
||||||
import TodaySurface from './TodaySurface.svelte';
|
import TodaySurface from './TodaySurface.svelte';
|
||||||
import * as App from '../../../wailsjs/go/api/App';
|
import * as App from '../../../wailsjs/go/api/App';
|
||||||
import { onDestroy, onMount } from 'svelte';
|
import { onDestroy, onMount } from 'svelte';
|
||||||
|
|
@ -134,6 +135,9 @@
|
||||||
<span class="workspace-title">{workspaceTitle}</span>
|
<span class="workspace-title">{workspaceTitle}</span>
|
||||||
<span class="workspace-type">{workspaceType}</span>
|
<span class="workspace-type">{workspaceType}</span>
|
||||||
</div>
|
</div>
|
||||||
|
<div class="workspace-search" aria-label="Workspace search">
|
||||||
|
<GlobalSearch />
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{#if displayedTools.length > 0}
|
{#if displayedTools.length > 0}
|
||||||
|
|
@ -196,9 +200,9 @@
|
||||||
.workspace-header {
|
.workspace-header {
|
||||||
display: flex;
|
display: flex;
|
||||||
align-items: center;
|
align-items: center;
|
||||||
justify-content: flex-start;
|
justify-content: space-between;
|
||||||
gap: 0.75rem;
|
gap: 1rem;
|
||||||
padding: 0.75rem 1rem;
|
padding: 0.65rem 1rem;
|
||||||
border-bottom: 1px solid #16213e;
|
border-bottom: 1px solid #16213e;
|
||||||
flex-shrink: 0;
|
flex-shrink: 0;
|
||||||
}
|
}
|
||||||
|
|
@ -224,11 +228,38 @@
|
||||||
background: #1a2a3a;
|
background: #1a2a3a;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.workspace-search {
|
||||||
|
width: min(27rem, 46vw);
|
||||||
|
min-width: 16rem;
|
||||||
|
flex-shrink: 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
.workspace-search :global(.global-search) {
|
||||||
|
padding: 0;
|
||||||
|
border-bottom: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.workspace-search :global(.global-search-box) {
|
||||||
|
background: #101626;
|
||||||
|
border-color: #243957;
|
||||||
|
}
|
||||||
|
|
||||||
|
.workspace-search :global(.global-search-results) {
|
||||||
|
left: 0;
|
||||||
|
right: 0;
|
||||||
|
top: calc(100% + 0.35rem);
|
||||||
|
}
|
||||||
|
|
||||||
@media (max-width: 720px) {
|
@media (max-width: 720px) {
|
||||||
.workspace-header {
|
.workspace-header {
|
||||||
align-items: stretch;
|
align-items: stretch;
|
||||||
flex-direction: column;
|
flex-direction: column;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.workspace-search {
|
||||||
|
width: 100%;
|
||||||
|
min-width: 0;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
.workspace-tabs {
|
.workspace-tabs {
|
||||||
|
|
@ -239,9 +270,12 @@
|
||||||
background: #12122a;
|
background: #12122a;
|
||||||
border-bottom: 1px solid #16213e;
|
border-bottom: 1px solid #16213e;
|
||||||
flex-shrink: 0;
|
flex-shrink: 0;
|
||||||
|
overflow-x: auto;
|
||||||
|
scrollbar-gutter: auto;
|
||||||
}
|
}
|
||||||
|
|
||||||
.workspace-tabs button {
|
.workspace-tabs button {
|
||||||
|
flex-shrink: 0;
|
||||||
min-height: 2rem;
|
min-height: 2rem;
|
||||||
padding: 0.35rem 0.8rem;
|
padding: 0.35rem 0.8rem;
|
||||||
border: 1px solid transparent;
|
border: 1px solid transparent;
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue